Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): comply with pep 440 for dev version str #1854

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Jun 29, 2023

  • Use 3.dev4 as development placeholder version string since 3.4.0+ is non-compliant with PEP 440 and rejected on e.g. pip install .
  • Use packaging.Version in update_version.py instead of rolling our own

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #1854 (de90b34) into develop (5190394) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           develop   #1854     +/-   ##
=========================================
- Coverage     72.2%   72.2%   -0.1%     
=========================================
  Files          256     256             
  Lines        56120   56114      -6     
=========================================
- Hits         40561   40552      -9     
- Misses       15559   15562      +3     
Impacted Files Coverage Δ
flopy/version.py 100.0% <100.0%> (+14.2%) ⬆️

... and 6 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review June 29, 2023 05:32
@wpbonelli wpbonelli merged commit 4f63366 into modflowpy:develop Jun 29, 2023
16 of 20 checks passed
@wpbonelli wpbonelli deleted the fix-version branch June 29, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant